upstream #1
Open
upstream #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update Travis configuration * Drop os, use default * Use focal for OS * Restore patch versions of ruby, rvm not pulling latest patch * Update local test/run.sh script for easier local testing * Add some old AR back, remove 3+ rubies, drop deprecated codeclimate gem * Lock sqlite3 for Ruby 2.5 * ActiveRecord 6.0 and 6.1 tests failing, add later * Drop 2.5 * Update gemspec, pry for dev support * 5.1.1 AR works, update test/run.sh * Fix support for ActiveRecord 5.2
In Ruby 3.0, positional arguments and keyword arguments will be separated. Ruby 2.7 will warn for behaviors that will change in Ruby 3.0. Co-authored-by: Igor Drozdov <[email protected]>
Changed inccorectly -> incorrectly on line 412 Co-authored-by: Gabriel <[email protected]>
Co-authored-by: Alex Brinkman <[email protected]>
Signed-off-by: Josh Branham <[email protected]>
As those should be passing or otherwise dealt with by the time this is merged
…r Rails >= 5.2 Use #write_cast_value instead of #set_attribute_was patch
… with Rails 7 Prefix 'attr_encrypted' to encrypt and decrypt methods to avoid clash with Rails 7 Adopted from PR: #425
…removed native gem support for Ruby 2.6
This project has been dead since 2018
* Start testing ruby 3 * Exclude older AR and newer Ruby combos * Add Ruby 3.0.6 as well * Exclude 3.0.6 and AR 5.x
Rails 7.1 will deprecate using the singleton ActiveSupport::Deprecation instance. This directly uses the one from ActiveRecord. Co-authored-by: Josh Branham <[email protected]>
* Use Github Actions for CI * Add back old Rails versions * Only test Rails 5 on Ruby 2.7 --------- Co-authored-by: Josh Branham <[email protected]>
Co-authored-by: Josh Branham <[email protected]>
* Add Josh and Mike to authors Signed-off-by: Josh Branham <[email protected]> * Update attr_encrypted.gemspec Signed-off-by: Josh Branham <[email protected]> --------- Signed-off-by: Josh Branham <[email protected]>
* Update README.md Signed-off-by: Josh Branham <[email protected]> * Update README.md Signed-off-by: Josh Branham <[email protected]> --------- Signed-off-by: Josh Branham <[email protected]>
…pend (#457) For example, when using the master branch of activerecord-multi-tenant, if activerecord-multi-tenant and attr_encrypted are listed in the Gemfile in that order, calling the reload method raises a SystemStackError. This happens because activerecord-multi-tenant extends Active Record’s reload method using prepend, while attr_encrypted extends it using an alias method. Here’s an example of how extending the same method with both prepend and alias methods in that order can result in a SystemStackError ``` class Hello def hello 'hello' end end Hello.prepend(Module.new do def hello super end end) Hello.class_eval do alias orig_hello hello def hello "#{orig_hello} world" end end Hello.new.hello #=> SystemStackError ``` However, reversing the order works: ``` class Hello def hello 'hello' end end Hello.class_eval do alias orig_hello hello def hello "#{orig_hello} world" end end Hello.prepend(Module.new do def hello super end end) Hello.new.hello #=> "hello world" ``` This issue can be resolved by standardizing the method extension to use prepend to avoid conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.