Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler version in install.sh #9

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

erikrikarddaniel
Copy link
Contributor

Unfortunately, I still couldn't build the container after you made a release. I think the problem was that if I didn't use --docker with the build command all worked because some other version of gcc was used.

Now, after explicitly depending on gcc >=4.7.0 in the meta.yaml file in the build recipe, the package builds with ioconda-utils build --packages sativa --docker --mulled-test pointing to my fork. With gcc versions from 10 and up, your version tests didn't work as expected, so I updated that.

When you have time, would you please check the PR and, when merged, make another release and I'll update the build scripts.

@amkozlov
Copy link
Owner

amkozlov commented Jan 8, 2024

Thanks! I simplified your fix just a bit, please try:

https://github.com/amkozlov/sativa/releases/tag/v0.9.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants