Replace separators found within keys #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirziai
approved these changes
Feb 3, 2020
|
Hi @amirziai, any plans for releasing changes from this PR on PyPI? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Separators that already exist within keys pose a risk when unpacking. This PR adds optional ability to replace separators found in keys with some other character
Also fixes some small typo in README.md
Bug Fixes/New Features
How to Verify
New tests: test_replace_separators_*
Side Effects
Does the pull request contain any side effects? This should list non-obvious things that have
changed in the request.
Resolves
Helps with #60
Tests
New tests: test_replace_separators_*
All tests passing
Code Reviewer(s)
@amir-ziai-zefr