Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for which warm_starting parameter was ignored in osqp plugin #13

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

LoreMoretti
Copy link
Contributor

Remove duplicated code.

Remove duplicated code.
@traversaro
Copy link
Contributor

Thanks for noticing! This is actually a bug, but I think the reason is that the second warm_start should be warm_starting for compatibility with osqp 1.0, see the docs: https://github.com/ami-iit/qpsolvers-eigen/tree/main/plugins/osqp#boolean-parameters . Can you change the PR to just fix the second if to use warm_starting ?

@traversaro
Copy link
Contributor

Thanks! This also fixes the code in

solver.setBooleanParameter("warm_starting", true);
.

@traversaro traversaro changed the title Update QpSolversEigenOsqp.cpp to remove duplicated code Fix bug for which warm_starting parameter was ignored in osqp plugin Nov 12, 2024
@traversaro
Copy link
Contributor

Thanks @LoreMoretti ! I updated the title to be more descriptive for future reference (as PR title end up in the release notes).

@traversaro traversaro merged commit 1a3c6e6 into ami-iit:main Nov 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants