Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflows): use GITHUB_OUTPUT instead of ::set-output #222

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

PixnBits
Copy link
Contributor

@PixnBits PixnBits commented Sep 29, 2023

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Description

replace

echo "::set-output name={name}::{value}"

with

echo "{name}={value}" >> $GITHUB_OUTPUT

Motivation and Context

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
these are now showing as warnings in the runs, e.g. https://github.com/americanexpress/one-app/actions/runs/6344142425

How Has This Been Tested?

americanexpress/one-app#1141

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • This change impacts caching for client browsers.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using parrot?

None

@PixnBits PixnBits requested a review from a team as a code owner September 29, 2023 17:09
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution to this repository. We will be reviewing your PR. In the meantime, please sign the CLA and make sure all status checks have passed.

@Matthew-Mallimo Matthew-Mallimo merged commit 67ac5b9 into main Oct 4, 2023
3 checks passed
@Matthew-Mallimo Matthew-Mallimo deleted the chore/workflow-output branch October 4, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants