Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

length check in match mock #130

Merged
merged 6 commits into from
Feb 21, 2022

Conversation

amexjake
Copy link
Contributor

@amexjake amexjake commented Jul 8, 2021

Attempts to address some issues when the length property is assumed from the mocks parameter of the matchMock utility.

Description

This attempts to address issue #99, where an error is thrown about there being no length property for mocks.

Requires #129 to be merged first.

Motivation and Context

This will throw a more helpful and verbose error if no mocks are defined for a scenario, or if for some reason an unexpected value is passed to the matchMock util, and thus give more insight into the error thrown in #99 when parrot is used in conjunction with One App.

How Has This Been Tested?

Unit tests have been written to account for these new errors.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • This change impacts caching for client browsers.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using parrot?

@amexjake amexjake requested a review from a team as a code owner July 8, 2021 23:29
Copy link

@AdamFoskit AdamFoskit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good

@amexjake amexjake requested a review from a user July 15, 2021 20:09
@github-actions
Copy link

This pull request is stale because it has been open 30 days with no activity.

@github-actions
Copy link

This pull request is stale because it has been open 30 days with no activity.

@JAdshead JAdshead merged commit ac7e433 into americanexpress:main Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants