This repository has been archived by the owner on May 15, 2024. It is now read-only.
feat: add required APIs for react streaming #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-forger
suggested changes
Mar 7, 2024
code-forger
previously approved these changes
Mar 8, 2024
JAdshead
reviewed
Mar 8, 2024
JAdshead
reviewed
Mar 8, 2024
JAdshead
previously requested changes
Mar 8, 2024
giulianok
previously requested changes
Mar 11, 2024
Matthew-Mallimo
commented
Mar 19, 2024
| | `enhancer` | `Function` | `false` | A [Redux enhancer] | | ||
| | `localsForBuildInitialState` | `Object` | `false` | Value to pass to [vitruvius]'s `buildInitialState` | | ||
| | `extraThunkArguments` | `Object` | `false` | Additional arguments to be passed to [Redux thunks] | | ||
| | name | type | required | value | |
There was a problem hiding this comment.
A lot of these changes are just formatting the tables to be readable raw
guym4c
previously approved these changes
Mar 20, 2024
| @@ -0,0 +1,97 @@ | |||
| import React from 'react'; | |||
| // eslint-disable-next-line import/no-extraneous-dependencies -- monorepo, this is at the root | |||
There was a problem hiding this comment.
Wouldn't it make more sense to include it in the devDependencies for this workspace than to disable the rule?
10xLaCroixDrinker
suggested changes
Mar 22, 2024
10xLaCroixDrinker
previously approved these changes
Mar 25, 2024
code-forger
reviewed
Mar 25, 2024
code-forger
dismissed stale reviews from giulianok and JAdshead
Resolved comments
code-forger
approved these changes
Mar 25, 2024
10xLaCroixDrinker
approved these changes
Mar 25, 2024
JAdshead
approved these changes
Mar 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
ReactStreamingContextandModuleContextcontexts.Adds a new hook
useAsyncModuleData.Motivation and Context
ReactStreamingContextwill be used to store streamed promises required to trigger Suspense boundaries.ModuleContextjust stores the name of the module. This will be used to scope the promises stored in theReactStreamingContextstore.useAsyncModuleDatais a hook that will tap into both of the above contexts. It will be the hook users use to get data into their component.How Has This Been Tested?
Unit tested. I've manually tested this locally to ensure it works, but not in its final form.
Types of Changes