Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

revert(holocron): redux react-redux peer deps #175

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

JAdshead
Copy link
Contributor

Description

This partially reverts 19d0755 which make redux and react-redux peer deps.

Motivation and Context

making redux and react redux peer deps should have been done as a breaking change.

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • This change impacts caching for client browsers.
  • This change adds additional environment variable requirements for Holocron users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using Holocron?

@JAdshead JAdshead merged commit fca187c into main Feb 22, 2024
4 checks passed
@JAdshead JAdshead deleted the revert/redux-peer-dep-change branch February 22, 2024 19:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants