Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install.sh if clause #39

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sebix
Copy link

@sebix sebix commented Nov 20, 2021

== with wildcard only works in bash, [[ is also bash-only, not bourne-shell which is used in this script.
To compare with wildcard in bourne-shell we can use the case statement

`==` with wildcard only works in bash, `[[` is also bash-only, not bourne-shell which is used in this script.
To compare with wildcard in bourne-shell we can use the case statement
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jdelglise
Copy link

Same issue encountered here, fixed by replacing #!/bin/sh by #!/bin/bash on my side

@sebix
Copy link
Author

sebix commented Nov 30, 2021

Switching to bash would have been the other solution, but that requires bash, probably adding a new dependency (which is often available but not on minimal installations). I therefore opted to stick with the bourne shell. But it's up to the maintainers to decide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants