Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest-preset): collect coverage from typescript files #63

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

smackfu
Copy link
Member

@smackfu smackfu commented Jul 7, 2023

Description

Add .ts and .tsx extensions to the coverage.

Motivation and Context

Given the common usage of Typescript, it's unexpected that they are not include in the coverage reporting.

How Has This Been Tested?

Validated that this config properly collects coverage from typescript files.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using amex-jest-preset-react?

Developers using typescript will have proper coverage values reported.

@Matthew-Mallimo Matthew-Mallimo requested a review from a team July 7, 2023 18:56
@10xLaCroixDrinker 10xLaCroixDrinker merged commit 125280a into main Jul 7, 2023
2 checks passed
@10xLaCroixDrinker 10xLaCroixDrinker deleted the smackfu-patch-1 branch July 7, 2023 19:05
oneamexbot added a commit that referenced this pull request Jul 7, 2023
# [8.1.0](v8.0.1...v8.1.0) (2023-07-07)

### Features

* **jest-preset:** collect coverage from typescript files ([#63](#63)) ([125280a](125280a))
@oneamexbot
Copy link
Contributor

🎉 This PR is included in version 8.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants