Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix #50

Merged
merged 17 commits into from
Jul 31, 2020
Merged

Bug fix #50

merged 17 commits into from
Jul 31, 2020

Conversation

lziq
Copy link
Contributor

@lziq lziq commented Jul 31, 2020

Issue #49 , if available:

Description of changes:

  1. Blobs now can support for inline space. However, it is still not able to support for multilines. I have created another Issue Support for blob multilines #48 for it.
  2. Remove \n as the end character for string, since string in some case should be able to support for multilines.
  3. Also remove \n as the end character for symbol.
  4. Comments now are supported in struct's field name.

@@ -51,7 +51,7 @@
"name": "punctuation.definition.string.begin.ion"
}
},
"end": "[\"\\n]",
"end": "\"",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add tests for the cases that caused the bugs and are fixed because of this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@lziq lziq linked an issue Jul 31, 2020 that may be closed by this pull request
@lziq lziq merged commit 6384029 into master Jul 31, 2020
@lziq lziq deleted the bugFix branch July 31, 2020 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some bugs
2 participants