Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Ion Error Formatted Document Shows No Problems #66

Open
almann opened this issue Aug 19, 2020 · 3 comments
Open

New Ion Error Formatted Document Shows No Problems #66

almann opened this issue Aug 19, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@almann
Copy link

almann commented Aug 19, 2020

When entering invalid Ion data in a new file, there are no reported problems. It is not clear that this is desired behavior or a bug.

  1. Open a new window.
  2. Open a new document.
  3. Set document to ion.
  4. Add invalid Ion data.

image

@therapon
Copy link
Contributor

Until the file is detected as Ion, with the extension .ion the Ion specific checks are not enabled. From the screen show it looks like the file is Untitled-1 which is the temporary buffer created for a new file. Extension's detection mechanism currently is not using the content of the file (ala Unix magic files)

@almann
Copy link
Author

almann commented Aug 19, 2020

Is this expected even if I set the file type directly? Note that syntax highlighting is working.

@therapon
Copy link
Contributor

If the file type is set while the buffer is not associated with a file yet it should use kick the LSP checks and mark errors.

@therapon therapon added the bug Something isn't working label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants