Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up macro addresses and add coverage for more edge cases #147

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

popematt
Copy link
Contributor

Issue #, if available:

#88

Description of changes:

  • Fixes up the macro IDs for add_macros, repeat (don't know how those were missed), as well as flatten, make_struct, etc. (those tests are/were not being run because ion-java doesn't support those yet).
  • Adds more test cases for make_list, make_sexp, make_struct, and flatten.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@popematt popematt merged commit 2c1661f into amazon-ion:main Dec 13, 2024
1 check passed
@popematt popematt deleted the more-tests branch December 13, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants