Update to [email protected] and remove re-export of ion-rs types #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zslayton
approved these changes
Oct 7, 2024
| _ => None, | ||
| } | ||
| } | ||
| fn as_u64(&self) -> Option<u64> { | ||
| match self.value() { | ||
| Value::Int(Int::I64(i)) => i.to_u64(), | ||
| Value::Int(Int::BigInt(i)) => i.to_u64(), | ||
| Value::Int(i) => i.as_i128()?.to_u64(), |
There was a problem hiding this comment.
...but weirdly, there's not an Int::as_u64() method.
There was a problem hiding this comment.
Tracking this as amazon-ion/ion-rust#840.
|
|
||
| // write the previously constructed ISL model into a schema file using `write_to` | ||
| let write_schema_result = expected_schema.write_to(&mut writer); | ||
| let write_schema_result = expected_schema.write_as_ion(&mut writer); |
There was a problem hiding this comment.
This works, though it can also be written writer.write(expected_schema).
There was a problem hiding this comment.
It can't be written that way because IslSchema does not implement WriteAsIon. This is because WriteAsIon implementations are allowed to write a single value, but an IslSchema is a sequence of top-level values.
| Ok(()) | ||
| } | ||
| Limit::Inclusive(value) if self.lower == self.upper => value.fmt(f), | ||
| _ => f.write_fmt(format_args!("range::[{},{}]", self.lower, self.upper)), |
There was a problem hiding this comment.
This is my first time seeing a manual invocation of format_args! in the wild. 🤔
| @@ -131,7 +131,7 @@ impl BuiltInTypeDefinition { | |||
| let mut constraints = vec![]; | |||
|
|
|||
| // parses an isl_type to a TypeDefinition | |||
| let type_name = isl_type.name(); | |||
| let type_name = isl_type.name().map(|x| x.to_owned()); | |||
There was a problem hiding this comment.
TIL that Option<&str> doesn't implement ToOwned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#137
Description of changes:
[email protected]WriteToIsl, so I removed theWriteToIsltrait in favor of implementingWriteAsIonion-schema-teststo the latest commit. (Required becauseion-rssupports only up to u128 for integers.)ranges.rsto useMinandMaxinstead ofUnbounded. That made it cleaner to implementWriteAsIon.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.