Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul the text parsers, port from nom to winnow #892

Merged
merged 33 commits into from
Jan 9, 2025

Avoid RawTextListIterator consuming a list's closing `]`

4085e38
Select commit
Loading
Failed to load commit list.
Merged

Overhaul the text parsers, port from nom to winnow #892

Avoid RawTextListIterator consuming a list's closing `]`
4085e38
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 9, 2025 in 1s

77.51% (target 80.00%)

View this Pull Request on Codecov

77.51% (target 80.00%)

Details

Codecov Report

Attention: Patch coverage is 80.66465% with 128 lines in your changes missing coverage. Please review.

Project coverage is 77.51%. Comparing base (46cc6b2) to head (4085e38).

Files with missing lines Patch % Lines
src/lazy/any_encoding.rs 51.04% 22 Missing and 25 partials ⚠️
src/lazy/binary/raw/v1_1/reader.rs 48.83% 10 Missing and 34 partials ⚠️
src/lazy/text/raw/reader.rs 87.71% 3 Missing and 4 partials ⚠️
src/lazy/binary/raw/reader.rs 85.00% 6 Missing ⚠️
src/lazy/encoder/write_as_ion.rs 0.00% 4 Missing ⚠️
src/lazy/text/raw/sequence.rs 92.98% 3 Missing and 1 partial ⚠️
src/lazy/text/raw/v1_1/reader.rs 92.30% 1 Missing and 3 partials ⚠️
src/lazy/text/parse_result.rs 85.00% 3 Missing ⚠️
src/lazy/encoder/text/v1_1/writer.rs 50.00% 0 Missing and 2 partials ⚠️
src/lazy/streaming_raw_reader.rs 94.11% 0 Missing and 2 partials ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #892      +/-   ##
==========================================
- Coverage   77.63%   77.51%   -0.12%     
==========================================
  Files         136      136              
  Lines       35094    34278     -816     
  Branches    35094    34278     -816     
==========================================
- Hits        27244    26572     -672     
+ Misses       5793     5728      -65     
+ Partials     2057     1978      -79

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov