Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switches from "encoding module" to "default module" #873

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Conversation

zslayton
Copy link
Contributor

@zslayton zslayton commented Dec 6, 2024

Builds on PR #872.

Switches encoding directive syntax from:

$ion_encoding::(/*...*/)

to:

$ion::(module _ /*...*/)

in anticipation of multi-module support.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zslayton zslayton marked this pull request as ready for review December 6, 2024 15:56
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 73.21429% with 30 lines in your changes missing coverage. Please review.

Project coverage is 77.61%. Comparing base (c103ca3) to head (3a844cd).

Files with missing lines Patch % Lines
src/lazy/system_reader.rs 56.89% 11 Missing and 14 partials ⚠️
src/lazy/encoder/writer.rs 20.00% 0 Missing and 4 partials ⚠️
src/lazy/expanded/compiler.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #873      +/-   ##
==========================================
- Coverage   77.62%   77.61%   -0.02%     
==========================================
  Files         136      136              
  Lines       34092    34143      +51     
  Branches    34092    34143      +51     
==========================================
+ Hits        26465    26499      +34     
- Misses       5659     5666       +7     
- Partials     1968     1978      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@popematt popematt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only 2 minor comments about the use of hard coded strings.

src/lazy/encoder/writer.rs Outdated Show resolved Hide resolved
src/lazy/expanded/compiler.rs Outdated Show resolved Hide resolved
Base automatically changed from bootstrap-macros to main December 6, 2024 16:47
@zslayton zslayton merged commit 9cf7f06 into main Dec 6, 2024
30 of 31 checks passed
@zslayton zslayton deleted the default-module branch December 6, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants