Ensure that FixedInt and FixedUInt handle zero-length integers #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
As I was looking at #757, I realized that there are cases where we may have a zero-width FixedInt (and maybe FixedUInt), so I'm updating their implementations to be able to read that correctly. While I was at it, I managed to get rid of the branching for positive and negative numbers in
FlexInt::read. No changes were needed inFlexUInt::read, but I added a test case for it anyway.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.