Add 1.1 binary reader support for bools #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zslayton
approved these changes
Apr 24, 2024
src/lazy/binary/raw/v1_1/value.rs
Outdated
Comment on lines
196
to
199
| return IonResult::decoding_error(format!( | ||
| "found a boolean value with an illegal type code representation: {:?}", | ||
| invalid | ||
| )) |
There was a problem hiding this comment.
I assume that this branch can't be reached unless there's a bug, in which case I think it's ok for this to be an unreachable!("...") panic.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #662
Description of changes:
This PR is the first in the chain of scalar value implementations, implementing the parsing of boolean values.
I've tried to keep each value type separated into its own PR, in order to keep the changes trivial and quick to review.. this is proving to be irritating, so I might merge a few.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.