Address PR feedback

amazon-ion · May 10, 2024 · 08c2313 · 08c2313
1 parent 84b9f34
commit 08c2313
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 22 deletions.
diff --git a/src/lazy/binary/raw/v1_1/reader.rs b/src/lazy/binary/raw/v1_1/reader.rs
@@ -311,18 +311,6 @@ mod tests {
         Ok(())
     }
 
-    macro_rules! assert_closely_eq {
-        ($x:expr, $y:expr, $d:expr) => {
-            let (a, b) = ($x, $y);
-            if ((a - b).abs() >= $d) {
-                panic!(
-                    "float not close enough to expected value: left: {}, right: {}",
-                    a, b
-                );
-            }
-        };
-    }
-
     #[test]
     #[allow(clippy::approx_constant)]
     fn floats() -> IonResult<()> {
@@ -351,16 +339,14 @@ mod tests {
         // TODO: Implement Half-precision.
         // assert_eq!(reader.next()?.expect_value()?.read()?.expect_float()?, 3.14);
 
-        assert_closely_eq!(
+        assert_eq!(
             reader.next()?.expect_value()?.read()?.expect_float()? as f32,
             3.1415927f32,
-            f32::EPSILON
         );
 
-        assert_closely_eq!(
+        assert_eq!(
             reader.next()?.expect_value()?.read()?.expect_float()?,
             std::f64::consts::PI,
-            f64::EPSILON
         );
 
         Ok(())

diff --git a/src/lazy/binary/raw/v1_1/value.rs b/src/lazy/binary/raw/v1_1/value.rs
@@ -255,12 +255,7 @@ impl<'top> LazyRawBinaryValue_1_1<'top> {
             }
             2 => todo!("implement half-precision floats"),
             0 => 0.0f64,
-            n => {
-                return IonResult::decoding_error(format!(
-                    "found a float value with an illegal bytes size: {:?}",
-                    n
-                ));
-            }
+            _ => unreachable!("found a float value with illegal byte size"),
         };
         Ok(RawValueRef::Float(value))
     }