Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds testing for macro-aware transcoding of Ion 1.1 streams from text and to binary. #67

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

tgregg
Copy link
Contributor

@tgregg tgregg commented Dec 10, 2024

Description of changes:

This builds on amazon-ion/ion-java#1010 and #66, adding testing for the remaining transcode format combinations (from text Ion 1.1 and to binary Ion 1.1).

After this PR is merged, users will be able to provide input in text or binary Ion 1.1, and request output in text or binary Ion 1.1, and the tool will perform macro-aware conversios between all possible combinations as necessary.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tgregg tgregg marked this pull request as ready for review December 10, 2024 02:41
Copy link

@jobarr-amzn jobarr-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testing approach relies on contracts between the file content and hardcoded assertions in code. I don't have a suggested patch and it already was that way before this PR, so nothing to block on.

Base automatically changed from ion-1-1-transcode to ion-1-1 December 12, 2024 23:51
@tgregg tgregg force-pushed the ion-11-transcode-text branch from 3bb6ee1 to a81ecb1 Compare December 12, 2024 23:55
@tgregg tgregg merged commit c9c1f5f into ion-1-1 Dec 12, 2024
@tgregg tgregg deleted the ion-11-transcode-text branch December 12, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants