Allows symbol table boundaries to be preserved when converting from Ion 1.0 to Ion 1.1. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on 1.0 to Ion 1.1.
popematt
reviewed
Jun 5, 2024
| @@ -419,8 +447,9 @@ static void rewriteIonFile(Path input, Path output, OptionsCombinationBase optio | |||
| options.importsForInputFile == null && | |||
| options.importsForBenchmarkFile == null && | |||
| options.format == Format.ION_BINARY && | |||
| options.ionMinorVersion != 1 && // TODO remove once support for writing system values via the Ion 1.1 writer is added. | |||
| IonUtilities.minorVersionsEqual(options.ionMinorVersion, input.toFile()) | |||
| // Minor versions may add new kinds of system values, so it is not possible to maintain system value | |||
There was a problem hiding this comment.
Minor versions could also add new symbols to the system symbol table. Do we need to account for that somehow to make sure that the transcoded SIDs still point to the correct text?
There was a problem hiding this comment.
Oof, yeah... looking into whether this is feasible.
There was a problem hiding this comment.
Proposed update to ion-java to enable this here: amazon-ion/ion-java#876
And I updated this PR to perform the transcoding. We'll have to make a minor update to ion-java once the 1.1 system symbol table is finalized.
….1 symbol ID during format conversion.
popematt
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #62
Description of changes:
This allows more direct performance comparisons between Ion 1.0 and Ion 1.1. Note: ion-java's 1.1 writer needs to flush upon encountering a system value in order to achieve comparable performance to the Ion 1.0 writer (see amazon-ion/ion-java#873).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.