Ensure that all empty PersistentLists are the same instance. #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
There's a problem in
kotlinx.collections.immutable
(described in Kotlin/kotlinx.collections.immutable#176) that was causingion-element-kotlin
to unnecessarily allocate large numbers of empty lists for unannotated values (and anywhere else that had a possibly-empty list).Unfortunately, we won't be able to use the fix from that PR until we can update
ion-element-kotlin
to Kotlin >= 1.9.This adds our own extension functions to work around the bug.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.