-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Factory methods for AHS AtomArrangments by AbdullahKazi500 #989
Draft
AbdullahKazi500
wants to merge
15
commits into
amazon-braket:main
Choose a base branch
from
AbdullahKazi500:AbdullahKazi500-patch-8
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feature: Factory methods for AHS AtomArrangments by AbdullahKazi500 #989
AbdullahKazi500
wants to merge
15
commits into
amazon-braket:main
from
AbdullahKazi500:AbdullahKazi500-patch-8
Commits on Jun 4, 2024
-
defined the SiteType enum and AtomArrangementItem dataclass to handle the coordinates and site types, ensuring validations. AtomArrangement Class: The class initializes with an empty list of sites. Add Method: Adds a coordinate to the arrangement with a site type. Retrieves a list of coordinates for a given index. Rounds coordinates to the nearest multiple of the given resolution. Factory Methods: Methods for creating square and rectangular lattice arrangements. Demonstrates creating a square lattice with specified boundary points and lattice constant.
Configuration menu - View commit details
-
Copy full SHA for 63cdf2b - Browse repository at this point
Copy the full SHA 63cdf2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bcd8b9 - Browse repository at this point
Copy the full SHA 5bcd8b9View commit details
Commits on Jun 7, 2024
-
I have cleaned up and properly formatted the code to enhance readability and maintainability. Here are the key changes made: Added all necessary imports at the beginning of the code. Defined a custom exception DiscretizationError. Organized and added necessary data classes (LatticeGeometry, DiscretizationProperties, AtomArrangementItem) and enums (SiteType). Implemented validation methods inside AtomArrangementItem to check coordinates and site types. Added docstrings to methods for better understanding. Implemented methods for adding coordinates, getting coordinate lists, iterating, getting length, and discretizing arrangements. Added factory methods for creating different lattice structures (square, rectangular, decorated Bravais, honeycomb, and Bravais lattices).
Configuration menu - View commit details
-
Copy full SHA for 05b43a9 - Browse repository at this point
Copy the full SHA 05b43a9View commit details
Commits on Jun 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ead9f97 - Browse repository at this point
Copy the full SHA ead9f97View commit details
Commits on Jun 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bd6f911 - Browse repository at this point
Copy the full SHA bd6f911View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebd1e08 - Browse repository at this point
Copy the full SHA ebd1e08View commit details -
Configuration menu - View commit details
-
Copy full SHA for a89c222 - Browse repository at this point
Copy the full SHA a89c222View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad9b803 - Browse repository at this point
Copy the full SHA ad9b803View commit details -
Configuration menu - View commit details
-
Copy full SHA for b293b94 - Browse repository at this point
Copy the full SHA b293b94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5dd7853 - Browse repository at this point
Copy the full SHA 5dd7853View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9b0701 - Browse repository at this point
Copy the full SHA a9b0701View commit details
Commits on Jun 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a800d28 - Browse repository at this point
Copy the full SHA a800d28View commit details -
Configuration menu - View commit details
-
Copy full SHA for f811125 - Browse repository at this point
Copy the full SHA f811125View commit details -
Configuration menu - View commit details
-
Copy full SHA for eabfbb3 - Browse repository at this point
Copy the full SHA eabfbb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca699aa - Browse repository at this point
Copy the full SHA ca699aaView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.