Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout issue #4

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Logout issue #4

wants to merge 4 commits into from

Conversation

am-casper
Copy link
Owner

What kind of change does this PR introduce?

Issue Number:

Fixes #

Did you add tests for your changes?

Snapshots/Videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

Have you read the contributing guide?

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

@am-casper am-casper temporarily deployed to TALAWA_ENVIRONMENT March 18, 2024 13:35 — with GitHub Actions Inactive
@am-casper am-casper force-pushed the logout-issue branch 2 times, most recently from 7e73d75 to 7c49ced Compare March 18, 2024 14:22
@am-casper am-casper temporarily deployed to TALAWA_ENVIRONMENT March 18, 2024 14:29 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.74%. Comparing base (8652d99) to head (26aba3c).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop       #4   +/-   ##
========================================
  Coverage    95.74%   95.74%           
========================================
  Files          152      152           
  Lines         7518     7518           
========================================
  Hits          7198     7198           
  Misses         320      320           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@am-casper am-casper deployed to TALAWA_ENVIRONMENT March 20, 2024 09:16 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants