Fixed invalid methods error in falcon 3 #32
Conversation
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
===========================================
- Coverage 100.00% 97.87% -2.13%
===========================================
Files 3 3
Lines 40 47 +7
===========================================
+ Hits 40 46 +6
- Misses 0 1 +1
Continue to review full report at Codecov.
|
falcon_apispec/falcon_plugin.py
Outdated
| @@ -28,6 +35,8 @@ def _generate_resource_uri_mapping(app): | |||
| for method_name, method_handler in route.method_map.items(): | |||
| if method_handler.__dict__.get("__module__") == "falcon.responders": | |||
There was a problem hiding this comment.
This one needs to be fixed as well, because I'll not work with falcon==3.0, neither.
| if method_handler.__dict__.get("__module__") == "falcon.responders": | |
| if method_handler.__module__ == "falcon.responders": |
There was a problem hiding this comment.
Hey @aslantar I'm using this awesome plugin, but I really would like to use it with falcon3, can I send these changes again in another PR - branch?, I've tested and seems it is working fine with falcon3, what do you think?
There was a problem hiding this comment.
@Javlopez, sure. I'd love to see the changes integrated.
There was a problem hiding this comment.
@Javlopez why do you need a separate PR with the same changes, instead of assisting @vuonglv1612 to get this one done?
There was a problem hiding this comment.
hello, sorry I didn't see this before, well just I found a way to send eveything in one PR, but you are right I can send my changes to @vuonglv1612 repo, for me is ok, I gonna send them today later
There was a problem hiding this comment.
Hey @aslantar I've opened a PR for in the fork vuonglv1612#1 just with the missing changes, @vuonglv1612 can you take a look please?
Best Regards
Add missing falcon responders
|
hey @aslantar when you have time could you please merge this PR? thank you so much |
|
Hi @alysivji can you help us to merge the PR?, thank you so much |
|
@alysivji Can this be merged? |
|
@alysivji It's been basically an year since the solution to this critical bug has been provided. Any reason the PR is not being merged? |
From falcon 3+, some methods was added which aren't in OpenAPI v3 valid methods.
We can filter invalid methods before add to mapping
Ref: #31