fix(server_openvr): 🐛 Make SteamVR chaperone consistent with ALVR #2493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmerp
commented
Nov 5, 2024
Comment on lines
225
to
232
| #ifdef __linux__ | ||
| else if (event.eventType == vr::VREvent_ChaperoneUniverseHasChanged | ||
| || event.eventType == vr::VREvent_ChaperoneRoomSetupFinished | ||
| || event.eventType == vr::VREvent_ChaperoneFlushCache | ||
| || event.eventType == vr::VREvent_ChaperoneSettingsHaveChanged | ||
| || event.eventType == vr::VREvent_SeatedZeroPoseReset | ||
| || event.eventType == vr::VREvent_StandingZeroPoseReset | ||
| || event.eventType == vr::VREvent_SceneApplicationChanged | ||
| || event.eventType == VendorEvent_ALVRDriverResync) { | ||
| if (hmd && hmd->m_poseHistory) { | ||
| auto rawZeroPose = GetRawZeroPose(); | ||
| if (rawZeroPose != nullptr) { | ||
| hmd->m_poseHistory->SetTransform(*rawZeroPose); | ||
| } | ||
| } | ||
| } | ||
| #endif |
There was a problem hiding this comment.
This code might not be needed anymore for linux
zmerp
force-pushed
the
chaperone-recentering
branch
from
d6fca67
to
31ae397
Compare
|
@The-personified-devil I wanted to discuss this. Do you think it's ok to override the game preference and re-reset the chaperone mode to stage when the game actually requested to reset to standing or seated? The benefit of forcing reset to stage is that we can remove the linux zero pose workaround. But this will cause glitches, for example when a game wants to reset to seated, then ALVR would undo it and you get teleported up. instead maybe we should keep track of which chaperone mode it's set to, and when pressing recentering we ask to zero pose with the current SteamVR chaperone mode |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often times, recentering using SteamVR, breaks ALVR calibration. With this PR we force SteamVR to revert to stage tracking any time it gets reset as standing or seated.
Not tested yet. The code that listens for recentering could cause an infinite loop.