Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use VRPN timestamps rather than generating them again #7

Merged
merged 5 commits into from
Jan 12, 2024

Conversation

njacquemin1993
Copy link
Contributor

When generating new timestamps based on ROS clock, it can modify the interval between 2 frames.

I obtained very close timestamps for consecutive frames sometimes (~100 microseconds interval). However the measurements were 4 milliseconds apart in reality.

Therefore I added the option to have the timestamps based on the VRPN timestamps intervals

Copy link
Owner

@alvinsunyixiao alvinsunyixiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I have left some comments on the time synchronization part.

src/tracker.cpp Outdated Show resolved Hide resolved
Copy link
Owner

@alvinsunyixiao alvinsunyixiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Just a small request to change the function name to CamelCase style.

include/vrpn_mocap/tracker.hpp Outdated Show resolved Hide resolved
@alvinsunyixiao
Copy link
Owner

I would suggest running colcon test --event-handlers console_direct+ on your local machine to debug CI failures.

@alvinsunyixiao alvinsunyixiao merged commit 636947e into alvinsunyixiao:main Jan 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants