Merge pull request grpc#21703 from yashykt/xdsfix

Fix 21686 to use the correct status
alvinsay · Jan 17, 2020 · 659653d · 659653d
2 parents 5969ce6 + 48139eb
commit 659653d
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/test/cpp/end2end/xds_end2end_test.cc b/test/cpp/end2end/xds_end2end_test.cc
@@ -1341,7 +1341,7 @@ using CdsTest = BasicTest;
 TEST_P(CdsTest, Vanilla) {
   SetNextResolution({});
   SetNextResolutionForLbChannelAllBalancers();
-  CheckRpcSendOk();
+  CheckRpcSendFailure();
   EXPECT_EQ(balancers_[0]->ads_service()->cds_response_state(),
             AdsServiceImpl::ACKED);
 }
@@ -1355,7 +1355,7 @@ TEST_P(CdsTest, WrongClusterType) {
       {{"application_target_name", std::move(cluster)}});
   SetNextResolution({});
   SetNextResolutionForLbChannelAllBalancers();
-  CheckRpcSendOk();
+  CheckRpcSendFailure();
   EXPECT_EQ(balancers_[0]->ads_service()->cds_response_state(),
             AdsServiceImpl::NACKED);
 }
@@ -1369,7 +1369,7 @@ TEST_P(CdsTest, WrongEdsConfig) {
       {{"application_target_name", std::move(cluster)}});
   SetNextResolution({});
   SetNextResolutionForLbChannelAllBalancers();
-  CheckRpcSendOk();
+  CheckRpcSendFailure();
   EXPECT_EQ(balancers_[0]->ads_service()->cds_response_state(),
             AdsServiceImpl::NACKED);
 }
@@ -1383,7 +1383,7 @@ TEST_P(CdsTest, WrongLbPolicy) {
       {{"application_target_name", std::move(cluster)}});
   SetNextResolution({});
   SetNextResolutionForLbChannelAllBalancers();
-  CheckRpcSendOk();
+  CheckRpcSendFailure();
   EXPECT_EQ(balancers_[0]->ads_service()->cds_response_state(),
             AdsServiceImpl::NACKED);
 }
@@ -1397,7 +1397,7 @@ TEST_P(CdsTest, WrongLrsServer) {
       {{"application_target_name", std::move(cluster)}});
   SetNextResolution({});
   SetNextResolutionForLbChannelAllBalancers();
-  CheckRpcSendOk();
+  CheckRpcSendFailure();
   EXPECT_EQ(balancers_[0]->ads_service()->cds_response_state(),
             AdsServiceImpl::NACKED);
 }