Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #97 #98

Closed
wants to merge 1 commit into from
Closed

Fixes #97 #98

wants to merge 1 commit into from

Conversation

grabbou
Copy link

@grabbou grabbou commented Jun 3, 2016

In jest (test runner) and react-native environment, the assignment is going to be ignored and the self remains pointing to whatever react-native defined for the sake of testing. Adding missing var here.

CC: @davidaurelio

In `jest` (test runner) and react-native environment, the assignment is going to be ignored and the `self` remains pointing to whatever react-native defined for the sake of testing. Adding missing var here.
@imhotep
Copy link
Collaborator

imhotep commented Jun 5, 2016

Same as Issue #96. I need a test that shows that the global breaks something.

@imhotep
Copy link
Collaborator

imhotep commented Jun 5, 2016

But since it's pretty minor I add your change anyway.

@imhotep imhotep closed this Jun 5, 2016
@Kureev
Copy link

Kureev commented Jun 5, 2016

I need a test that shows that the global breaks something.

Well, here we go: https://github.com/facebook/react-native/pull/7899/files#diff-781111e0db5cf5c6cc9b56a63fdfcbf6R31 test breaks on this line.

That's the source: https://github.com/facebook/react-native/blob/master/local-cli/rnpm/link/src/ios/addFileToProject.js

@grabbou
Copy link
Author

grabbou commented Jun 5, 2016

In general, I consider this as a type error... I can't think of any case where assigning to global context would be desirable (also - esp. that we overwrite that for every new PbxFile). BTW - we don't need it at all in that case actually, passing this would have the same effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants