-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scala object serializer supports copying. #16
Scala object serializer supports copying. #16
Conversation
Oh drat - I had to push to a fork of this repository, so could someone approve the failing CI workflow run, please? |
Thanks @danischroeter for triggering the workflow run. Unfortunately it failed when building for Scala 2.12; I've pushed a new commit (and this time, I ran the full cross build locally, lesson learned). Would you trigger the CI workflow again when you have a moment? |
@danischroeter This is odd - the CI build is still failing, but with this error:
7. I've not changed any of the workflow configuration in this PR, so I assume this is a transient glitch - perhaps due to the node switch from node12 to node16? Other than asking you to re-trigger again, I'm not sure what to do. If this failure is repeatable, then perhaps running the CI action on branch |
Jep I already created another issue... #17 |
I tried re-triggering the CI build on the Americium repository, this uses a later version of It's working nicely right now, finding SBT. An excerpt: jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up JDK 17
uses: actions/setup-java@v4
with:
java-version: '17'
distribution: 'temurin'
cache: 'sbt'
- name: Run tests
run: sbt +test |
@danischroeter I took the liberty of upgrading the GitHub workflow steps to v4 for checkout and Java setup. I don't know whether you folks have strong feelings about sticking with v2, but if you're happy with the upgrade being bundled in with this PR, please re-trigger the CI build. If not, let me know and I'll |
Drat - I only cutover the Another re-trigger, please... 😅 |
@sageserpent-open thx for the effort! |
@danischroeter no problem, sorry it didn’t work. I’ll remove that last commit as it’s just noise on this PR and wait for you folks to come back as and when you’re ready. |
@sageserpent-open |
…nd-trip behaviour of for `ScalaObjectSerializer`. Test passes, as expected.
… copying behaviour of for `ScalaObjectSerializer`. Test fails, as expected. Now to fix it...
@danischroeter Excellent, thanks. I've rebased and force-pushed. Would you trigger the build again, please... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thx - just one small testing improvement.
core/src/test/scala/io/altoo/serialization/kryo/scala/testkit/AbstractKryoTest.scala
Show resolved
Hide resolved
…jectSerializerTest` - the tests themselves now assert on *identity*, but the helpers are used to assert on *state*.
@sageserpent-open thx for your contribution! We planned to do a release of scala-kryo-serialization in ~ 2weeks when doing upgrades also for pekko 1.1. Or if it's very crucial for you we can do a release for your change... |
@danischroeter, @nvollmar , it was a pleasure working with you folks. I’m in no hurry - got a workaround in place, just wanted to contribute the fix upstream. I’ll keep an eye out for your next release. Cheers for now… |
This follows on from altoo-ag/akka-kryo-serialization#297.
I've broken up the PR into three commits.
ScalaObjectSerializer
.