Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a timeout argument to _exec_command #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dhirschfeld
Copy link

Fixes #15

@dhirschfeld
Copy link
Author

This is the minimum fix required to get fs.sshfs working for my usecase.

@dhirschfeld dhirschfeld reopened this Jul 21, 2018
@dhirschfeld
Copy link
Author

This appears to have caused something else to hang? I don't think this change should have done that.

@althonos
Copy link
Owner

@dhirschfeld: I think the hang comes from additional tests Will has added to Pyfilesystem2 in the latest release. They also cause one of my other extensions to hang. I'll investigate.

@willmcgugan
Copy link
Contributor

Is that the worker threads change to copy/move? Could have exposed a thread-safety issue.

I've just recalled there is a thread_safe meta value. I should probably do a non-threaded copy if that is False.

@althonos
Copy link
Owner

@willmcgugan : probably, yes !

Still, I expected this extension to be thread-safe since I'm locking whenever I access the underlying _sftp attribute !

@dhirschfeld
Copy link
Author

RE: thread safety, see also #17.

@codecov-io
Copy link

codecov-io commented Sep 2, 2018

Codecov Report

Merging #16 into master will decrease coverage by 0.63%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   97.41%   96.78%   -0.64%     
==========================================
  Files           5        5              
  Lines         310      311       +1     
==========================================
- Hits          302      301       -1     
- Misses          8       10       +2
Impacted Files Coverage Δ
fs/sshfs/sshfs.py 95.28% <66.66%> (-0.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f57437...c0ed6ab. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

listdir hangs indefinitely
4 participants