-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a timeout argument to _exec_command #16
base: master
Are you sure you want to change the base?
Conversation
This is the minimum fix required to get |
This appears to have caused something else to hang? I don't think this change should have done that. |
@dhirschfeld: I think the hang comes from additional tests Will has added to |
Is that the worker threads change to copy/move? Could have exposed a thread-safety issue. I've just recalled there is a |
@willmcgugan : probably, yes ! Still, I expected this extension to be thread-safe since I'm locking whenever I access the underlying |
RE: thread safety, see also #17. |
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
- Coverage 97.41% 96.78% -0.64%
==========================================
Files 5 5
Lines 310 311 +1
==========================================
- Hits 302 301 -1
- Misses 8 10 +2
Continue to review full report at Codecov.
|
629b302
to
fe68818
Compare
dca0b4f
to
ca1aa0d
Compare
Fixes #15