Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

listdir hangs indefinitely #15

Closed
dhirschfeld opened this issue Jul 21, 2018 · 1 comment · May be fixed by #16
Closed

listdir hangs indefinitely #15

dhirschfeld opened this issue Jul 21, 2018 · 1 comment · May be fixed by #16
Labels
bug something does not work fixed associated bug was fixed
Milestone
0.9.0

Comments

@dhirschfeld
Copy link

Just trying to use fs.sshfs to access an sftp server but I'm finding that listdir is hanging indefinitely.

I've tracked it down to this line:

fs.sshfs/fs/sshfs/sshfs.py

Line 303 in 33f981b

uname_sys = self._exec_command("uname -s")

...which calls the paramiko SSHClient.exec_command without a timeout argument:

fs.sshfs/fs/sshfs/sshfs.py

Lines 294 to 295 in 33f981b

_, out, err = self._client.exec_command(cmd)
return out.read().strip() if not err.read().strip() else None

Unfortunately, for whatever reason this seems to never return for me.
dhirschfeld added a commit to dhirschfeld/fs.sshfs that referenced this issue Jul 21, 2018
@dhirschfeld
Add a timeout argument to _exec_command
c0ed6ab 
Fixes althonos#15
@dhirschfeld dhirschfeld mentioned this issue Jul 21, 2018
Open
@althonos althonos added the bug something does not work label Jul 22, 2018
@althonos althonos added this to the 0.9.0 milestone Sep 3, 2018
@althonos
Copy link
Owner

Fixed in 44faa73.

I'm not ignoring for eventual socket errors, but raising them, since this is what the rest of the functions do (handle filesystem logic, but pass network errors transparently).

@althonos althonos added the fixed associated bug was fixed label Nov 22, 2018
@bartekre bartekre mentioned this issue Feb 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something does not work fixed associated bug was fixed
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

Add a timeout argument to _exec_command dhirschfeld/fs.sshfs
2 participants
@dhirschfeld @althonos