Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.8 support and use trusted publisher release process #22

Merged
merged 5 commits into from
Feb 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/install_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python_version: ["3.8", "3.9", "3.10", "3.11"]
python_version: ["3.9", "3.10", "3.11"]
os: [ubuntu-latest, macos-latest]
runs-on: ${{ matrix.os }}
steps:
Expand Down
29 changes: 17 additions & 12 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
@@ -1,19 +1,24 @@
name: Release
on:
release:
types: [published]

name: Release
jobs:
pypi:
pypi-publish:
name: PyPI Release
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Remove docs before release
run: rm -rf docs/
- name: PyPI Upload
uses: alteryx/gh-action-pypi-upload@v2
env:
PYPI_USERNAME: ${{ secrets.PYPI_USERNAME }}
PYPI_PASSWORD: ${{ secrets.PYPI_PASSWORD }}
TEST_PYPI_USERNAME: ${{ secrets.TEST_PYPI_USERNAME }}
TEST_PYPI_PASSWORD: ${{ secrets.TEST_PYPI_PASSWORD }}
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
- name: Install deps
run: |
python -m pip install --quiet --upgrade pip
python -m pip install --quiet --upgrade build
python -m pip install --quiet --upgrade setuptools
- name: Remove build artifacts and docs
run: |
rm -rf .eggs/ dist/ build/ docs/
- name: Build distribution
run: python -m build
- name: Publish package distributions to PyPI
uses: pypa/gh-action-pypi-publish@release/v1
6 changes: 3 additions & 3 deletions .github/workflows/unit_tests_with_latest_deps.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python_version: ["3.8", "3.9", "3.10", "3.11"]
python_version: ["3.9", "3.10", "3.11"]
featuretools_version: ["main", "release"]
steps:
- name: Checkout repository
Expand Down Expand Up @@ -40,14 +40,14 @@ jobs:
name: Install latest release of Featuretools
run: |
python -m pip install --force-reinstall featuretools
- if: ${{ matrix.python_version == 3.8 && matrix.featuretools_version == 'release'}}
- if: ${{ matrix.python_version == 3.9 && matrix.featuretools_version == 'main'}}
name: Generate coverage args
run: echo "coverage_args=--cov=premium_primitives --cov-config=../pyproject.toml --cov-report=xml:../coverage.xml" >> $GITHUB_ENV
- name: Run unit tests
run: |
cd unpacked_sdist
python -m pytest -n auto -s -vv premium_primitives/ ${{ env.coverage_args }}
- if: ${{ matrix.python_version == 3.8 && matrix.featuretools_version == 'release'}}
- if: ${{ matrix.python_version == 3.9 && matrix.featuretools_version == 'main'}}
name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
with:
Expand Down
5 changes: 2 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ classifiers = [
"Topic :: Scientific/Engineering",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand All @@ -27,11 +26,11 @@ maintainers = [
]
keywords = ["feature engineering", "data science", "machine learning"]
license = {text = "BSD 3-clause"}
requires-python = ">=3.8,<4"
requires-python = ">=3.9,<4"
dependencies = [
"numpy >= 1.21.0",
"pandas >= 1.5.0",
"featuretools >= 1.5.0, <2.0.0",
"featuretools >= 1.5.0",
"woodwork >= 0.8.1",
"nltk >= 3.4.5",
"scikit-learn >= 0.20.0",
Expand Down
5 changes: 3 additions & 2 deletions release_notes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@
Release Notes
-------------

v0.0.3 Feb 7, 2024
==================
Future Release
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went ahead and deleted the v0.0.3 release and the tag since it never got released due to project auth problems.

==============
* Remove pandas version upper bound restriction and add Python 3.11 tests (:pr:`16`)
* Remove support for Python 3.8 (:pr:`22`)

v0.0.2 May 9, 2023
==================
Expand Down
Loading