Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix install test and uncap kaleido #4423
Fix install test and uncap kaleido #4423
Changes from 28 commits
3505b67
ddcc0f2
381bd2d
9975d03
1ee459d
ce422b5
b00d604
867090c
ac13851
cf097ee
8f3af8c
8b6288f
314460c
d51cac3
54d3753
9e00b9e
6c23f1c
787a2a5
4213a84
1c7276d
5f8a18a
bceff5b
f5b99ca
34996d5
a002301
ebb35cd
dd39558
1d9201b
c65fa71
cd3f4f8
2b11a69
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whenever the install_tests would use cache, the test would fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, do you think it's noticably slower since we're not using the cache? If so, by how much?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interestingly the time it takes varies.
The latest commit (2b11a69) has the time that ubuntu takes for this step to be 8 seconds. For MacOS it takes 40 seconds for python3.9 and 3 minutes for python3.11.
Conversely, the second latest commit (cd3f4f8) has the time that ubuntu takes hover around 1 minute. MacOS hovers at around 40 seconds.
I can't say for sure how much slower it is without cache because it didn't work with cache enabled. I can go test to see if I can get cache working (hopefully it doesn't erase the approvals).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I was having trouble with caches in other OS repos recently and ended up removing them because they were failing too often.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally these were only meant for mac m1 tests to pass, but windows tests also needs these settings for testing, else some tests hang forever, causing workers to fail.