-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed first batch from default algorithm #4215
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4215 +/- ##
========================================
+ Coverage 84.4% 99.7% +15.3%
========================================
Files 349 349
Lines 38294 38284 -10
========================================
+ Hits 32320 38165 +5845
+ Misses 5974 119 -5855
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nitpicks but otherwise looks great!
assert "Label Encoder" in pipeline_error["Parameters"] | ||
assert ( | ||
"Label Encoder" in pipeline_error["Parameters"] | ||
or "Mock Classifier" in pipeline_error["Parameters"] | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question here, why did this have to change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously, our mock didn't actually work. We now check to see that the mock classifier pipelines appear in the results.
c1e1132
to
975e275
Compare
975e275
to
5a0f530
Compare
Resolves #4219