Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug when search result is inside description of external post #2710

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

george-gca
Copy link
Collaborator

Fixed a very specific bug that was happening when, for example, searching for the word round, which caused this:

image

After a lot of debugging I found out that the search result was in the svg icon definition. Finally got to fix this.

image

@george-gca george-gca merged commit fdaed74 into alshedivat:master Sep 20, 2024
3 checks passed
@george-gca george-gca deleted the fix_search branch September 20, 2024 22:04
meiqing-wang pushed a commit to meiqing-wang/meiqing-wang.github.io that referenced this pull request Oct 13, 2024
…lshedivat#2710)

Fixed a very specific bug that was happening when, for example,
searching for the word `round`, which caused this:


![image](https://github.com/user-attachments/assets/d6009462-ae03-4bc2-9ee3-60cb16dce20c)

After a lot of debugging I found out that the search result was in the
svg icon definition. Finally got to fix this.


![image](https://github.com/user-attachments/assets/cc179ea1-e9b8-4695-b98a-adf1472ecca5)

Signed-off-by: George Araújo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant