Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update entry_point.sh #2707

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Update entry_point.sh #2707

merged 1 commit into from
Sep 26, 2024

Conversation

pourmand1376
Copy link
Collaborator

No description provided.

@george-gca
Copy link
Collaborator

Can you check if this fixes it @0xAdriaTorralba?

@0xAdriaTorralba
Copy link

Can you check if this fixes it @0xAdriaTorralba?

Will do ASAP.

@0xAdriaTorralba
Copy link

Tried the fix (reverted to the "old" Gemfile.lock) and copied the entry_point.sh proposed here and it fails.

@pourmand1376
Copy link
Collaborator Author

pourmand1376 commented Sep 25, 2024

Thanks for testing it.

if you want to test it, you have to replace the docker-compose.yaml to build the image instead of using the upper-stream image. This is because the entry_point.sh is built into image and will change only when a new image is pushed.

# this file uses prebuilt image in dockerhub
services:
  jekyll:
    build: .
    ports:
      - 8080:8080
      - 35729:35729
    volumes:
      - .:/srv/jekyll
    environment:
      - JEKYLL_ENV=development

I think if you revert the Gemfile into the previous version and then commit. After that, you shouldn't have any problems when having local deployments.

@pourmand1376 pourmand1376 merged commit 6265269 into master Sep 26, 2024
1 check passed
@pourmand1376
Copy link
Collaborator Author

I merged the change since I'm pretty much sure that line was problematic and I should've changed that since we've added Gemfile.lock into repository.

@pourmand1376 pourmand1376 deleted the pourmand1376-patch-1 branch September 26, 2024 05:12
@george-gca
Copy link
Collaborator

@0xAdriaTorralba can you test again in the same way? Now the docker image have the updated entry_point.sh.

@pourmand1376
Copy link
Collaborator Author

Yep. Just make sure to pull new image.

kastnerp added a commit to SustainableUrbanSystemsLab/SustainableUrbanSystemsLab.github.io that referenced this pull request Sep 26, 2024
meiqing-wang pushed a commit to meiqing-wang/meiqing-wang.github.io that referenced this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants