Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search_enabled -> bib_search #2560

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

CheariX
Copy link
Contributor

@CheariX CheariX commented Jul 10, 2024

In #2523, I did a copy&paste error with 07d6e61

I used the global search_enabled config key instead of the correct bib_search key.

This PR fixed it.

@george-gca
Copy link
Collaborator

george-gca commented Jul 10, 2024

I think it would be better to move the include of the script from _includes/scripts/misc.liquid to the publications page, since only that page uses bibsearch.js and currently it is being included in all pages as long as the config is set to use it. Can you include this change in this PR?

@CheariX
Copy link
Contributor Author

CheariX commented Jul 10, 2024

Hm. Good point. In my personal setup, I use the bibsearch box on many pages. So it made sense to include it in misc.liquid. But most people maybe only have a single bib page.

@george-gca
Copy link
Collaborator

Maybe you could change for the template, and keep it as is in your personal site since it makes sense.

@CheariX
Copy link
Contributor Author

CheariX commented Jul 10, 2024

Sure. I think, this makes sense for most people, see f58ffca.

An alternative would be create a file in. include/bibsearch.liquid and include it. This would allow other people to easily integrate it. What do you think?

@george-gca
Copy link
Collaborator

An alternative would be create a file in. include/bibsearch.liquid and include it. This would allow other people to easily integrate it. What do you think?

I like this idea most, makes sense.

@CheariX
Copy link
Contributor Author

CheariX commented Jul 12, 2024

Done.

(I had some Git hiccups, but I think I could solve it with a force push. )

@george-gca george-gca merged commit 83e8a64 into alshedivat:master Jul 12, 2024
3 checks passed
@george-gca
Copy link
Collaborator

Thanks for the changes. Just out of curiosity, how are you using this search in other parts of your site? I mean, what code changes should you made to reuse this somewhere?

@CheariX
Copy link
Contributor Author

CheariX commented Jul 14, 2024

I manage a lot of content on my site using BibTeX. For example, I list my teaching courses, supervised theses, and press articles.

I found this to be the easiest method since I use Zotero to manage my papers, theses, and other resources anyway, and Zotero has a great auto-export to BibTeX feature (Better BibTeX extension).

@CheariX CheariX deleted the fix-bibsearch-config branch July 14, 2024 19:23
HangJung97 added a commit to HangJung97/HangJung97.github.io that referenced this pull request Jul 15, 2024
- Include updates and fixes from (alshedivat/al-folio#2549) to (alshedivat/al-folio#2560)
- Update till commit 8ffd34c on Jul 14, 2024
Suraj-Bhor pushed a commit to Suraj-Bhor/suraj-bhor.github.io that referenced this pull request Aug 13, 2024
In alshedivat#2523, I did a copy&paste error with
alshedivat@07d6e61

I used the global `search_enabled` config key instead of the correct
`bib_search` key.

This PR fixed it.
meiqing-wang pushed a commit to meiqing-wang/meiqing-wang.github.io that referenced this pull request Oct 13, 2024
In alshedivat#2523, I did a copy&paste error with
alshedivat@07d6e61

I used the global `search_enabled` config key instead of the correct
`bib_search` key.

This PR fixed it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants