-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: search_enabled -> bib_search #2560
Conversation
I think it would be better to move the include of the script from _includes/scripts/misc.liquid to the publications page, since only that page uses |
Hm. Good point. In my personal setup, I use the bibsearch box on many pages. So it made sense to include it in |
Maybe you could change for the template, and keep it as is in your personal site since it makes sense. |
Sure. I think, this makes sense for most people, see f58ffca. An alternative would be create a file in. |
I like this idea most, makes sense. |
1c02b0a
to
d1b6708
Compare
Done. (I had some Git hiccups, but I think I could solve it with a force push. ) |
Thanks for the changes. Just out of curiosity, how are you using this search in other parts of your site? I mean, what code changes should you made to reuse this somewhere? |
I manage a lot of content on my site using BibTeX. For example, I list my teaching courses, supervised theses, and press articles. I found this to be the easiest method since I use Zotero to manage my papers, theses, and other resources anyway, and Zotero has a great auto-export to BibTeX feature (Better BibTeX extension). |
- Include updates and fixes from (alshedivat/al-folio#2549) to (alshedivat/al-folio#2560) - Update till commit 8ffd34c on Jul 14, 2024
In alshedivat#2523, I did a copy&paste error with alshedivat@07d6e61 I used the global `search_enabled` config key instead of the correct `bib_search` key. This PR fixed it.
In alshedivat#2523, I did a copy&paste error with alshedivat@07d6e61 I used the global `search_enabled` config key instead of the correct `bib_search` key. This PR fixed it.
In #2523, I did a copy&paste error with 07d6e61
I used the global
search_enabled
config key instead of the correctbib_search
key.This PR fixed it.