Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing/py-execnet: new aport #6060

Closed
wants to merge 1 commit into from
Closed

testing/py-execnet: new aport #6060

wants to merge 1 commit into from

Conversation

dimon222
Copy link
Contributor

Depends on #6059

@dimon222 dimon222 mentioned this pull request Jan 19, 2019
Closed
@dimon222
Copy link
Contributor Author

Tests are outdated (tox), so they cannot complete on current version of pytest/tox combo. Currently I left them in code, but option="!check". If its preferable to completely remove them (without hoping they ever get to be fixed?), it can be done and I'm okay with that.

@andypost andypost added the A-new Adds a new aport package label Jan 21, 2019
@andypost
Copy link
Contributor

andypost commented Jan 22, 2019 •
edited
Loading

Let's add options="!check" with comment to issue with test fail report and commit this one

@andypost
Copy link
Contributor

Commited as a70749f
Meanwhile https://build.alpinelinux.org/buildlogs/build-edge-armhf/testing/py-apipkg/py-apipkg-1.5-r0.log

@andypost andypost closed this Jan 22, 2019
@dimon222
Copy link
Contributor Author

Tests got fixed in official repo, but sadly not yet part of any existing release. Once release happens, we can enable them right after.

@andypost
Copy link
Contributor

If tests are fixed then we can add patch from commits

@andypost
Copy link
Contributor

I guess we need https://github.com/pytest-dev/execnet/pull/90.patch

@dimon222
Copy link
Contributor Author

dimon222 commented Jan 23, 2019 •
edited
Loading

Might be risks with that as master branch might have changed definition of functions since last release (this pytest is not the only commit that was done since release). Unless we apply all the tree patches since last release... Also another fix is also required to be as patch probably.
pytest-dev/execnet#82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andypost andypost andypost left review comments

Assignees
No one assigned
Labels
A-new Adds a new aport package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimon222 @andypost