Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom frameset restore #42

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

custom frameset restore #42

wants to merge 3 commits into from

Conversation

gagbo
Copy link

@gagbo gagbo commented Aug 3, 2021

Fixes #41

@gagbo
feat(frames): customize frameset-restore calls
243b006 
All documentation for the custom variables options comes
from 3af9e84ff59811734dcbb5d55e04e1fdb7051e77
@gagbo
doc: fix checkdoc issues
1602fb9
@gagbo gagbo force-pushed the feat/custom_frameset-restore branch from 94f7b22 to 1602fb9 Compare August 3, 2021 20:00
@gagbo
Copy link
Author

gagbo commented Aug 3, 2021

I'm not 100% positive that the documentation in the defcustom matches earlier versions of Emacs, I still need to check that

@alphapapa
Copy link
Owner

Ok, please let me know when it's ready. Also, please lint with makem.sh, e.g. Checkdoc will complain about those docstrings. And please put the nil initial values on the same line as the variable name.

@alphapapa alphapapa added the enhancement New feature or request label Aug 4, 2021
@gagbo
Copy link
Author

gagbo commented Aug 4, 2021

Sure I'll lint with makem.sh once I checked frameset-restore on 26.3 and 27.1/2; I already ran checkdoc so I wonder if it's going to flag other things in docstrings

@gagbo gagbo marked this pull request as draft August 4, 2021 06:47
@gagbo
Copy link
Author

gagbo commented Aug 11, 2021

Sorry I’m a little busy, hopefully I’ll find some time to finish it soon TM.

I had time to check the API of frameset-restore on emacs-26 and emacs-27 branches, and it’s strictly the same, so the only step left is to lint with makem.sh

@gagbo gagbo marked this pull request as ready for review September 8, 2021 16:10
@gagbo
Copy link
Author

gagbo commented Sep 8, 2021

I passed makem, but I had issues with spellchecking, not sure it's passing

@alphapapa alphapapa self-assigned this Sep 8, 2021
@alphapapa alphapapa added this to the 0.4 milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alphapapa alphapapa

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.4
Development

Successfully merging this pull request may close these issues.

How to pass extra arguments to frameset-restore through burly-open-url ?
2 participants
@gagbo @alphapapa