Skip to content

Commit

Permalink
Fix rubocop offenses
Browse files Browse the repository at this point in the history
  • Loading branch information
alexandermeindl committed Jan 31, 2024
1 parent 5788828 commit 10fbaba
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ require:

AllCops:
TargetRubyVersion: 2.7
TargetRailsVersion: 5.2
TargetRailsVersion: 6.1
NewCops: enable

Rails:
Expand Down
4 changes: 2 additions & 2 deletions lib/tasks/redmine_plugin_kit.rake
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ namespace :redmine_plugin_kit do
if name == 'redmine'
Setting[setting.to_sym] = value
else
plugin_name = "plugin_#{name}".to_sym
plugin_name = :"plugin_#{name}"
plugin_settings = Setting[plugin_name]
plugin_settings[setting] = value
Setting[plugin_name] = plugin_settings
Expand Down Expand Up @@ -74,7 +74,7 @@ namespace :redmine_plugin_kit do
if name == 'redmine'
puts Setting.send(setting)
else
plugin_name = "plugin_#{name}".to_sym
plugin_name = :"plugin_#{name}"
plugin_settings = Setting[plugin_name]
puts plugin_settings[setting]
end
Expand Down
4 changes: 2 additions & 2 deletions test/units/loader_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -144,13 +144,13 @@ def test_do_not_allow_helper_if_controller_patch_exists_as_hash
def test_load_model_hooks
hooks = RedminePluginKit::Loader.new(plugin_id: @plugin_id).load_model_hooks!

assert hooks.is_a? Module
assert_kind_of Module, hooks
end

def test_load_hooks
hooks = RedminePluginKit::Loader.new(plugin_id: @plugin_id).load_view_hooks!

assert hooks.is_a? Module
assert_kind_of Module, hooks
end

def test_load_macros
Expand Down

0 comments on commit 10fbaba

Please sign in to comment.