Skip to content

Commit

Permalink
Update for redmine 6
Browse files Browse the repository at this point in the history
  • Loading branch information
alexandermeindl committed Nov 10, 2024
1 parent 6084d88 commit 3b813c0
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 11 deletions.
11 changes: 3 additions & 8 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ require:
- rubocop-minitest

AllCops:
TargetRubyVersion: 2.7
TargetRailsVersion: 6.1
TargetRubyVersion: 3.1
TargetRailsVersion: 7.2
NewCops: enable

Rails:
Expand Down Expand Up @@ -86,7 +86,6 @@ Style/AutoResourceCleanup:
Style/ExpandPathArguments:
Enabled: true
Exclude:
- additionals.gemspec
- test/**/*

Style/FrozenStringLiteralComment:
Expand All @@ -105,7 +104,7 @@ Style/OptionHash:
- parameters
- settings
Exclude:
- lib/additionals/patches/*.rb
- lib/redmine_issue_view_columns/patches/*.rb

# postgresql and mysql are supported
# autodetect does not work without database configuration
Expand Down Expand Up @@ -139,10 +138,6 @@ Naming/VariableNumber:
Exclude:
- 'test/**/*'

Style/StringConcatenation:
Exclude:
- 'app/views/additionals/_select2_ajax_call.*'

# see https://github.com/rubocop/rubocop-rails/issues/578
# redmine does not use load_defaults: https://rails.rubystyle.guide/#config-defaults
Rails/RedundantPresenceValidationOnBelongsTo:
Expand Down
2 changes: 1 addition & 1 deletion app/models/issue_view_column.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

class IssueViewColumn < AdditionalsApplicationRecord
class IssueViewColumn < ApplicationRecord
belongs_to :project

scope :sorted, -> { order :position }
Expand Down
4 changes: 2 additions & 2 deletions init.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
author_url 'https://alphanodes.com/'
description 'Customize shown columns in subtasks and related issues on issue page'
version RedmineIssueViewColumns::VERSION
requires_redmine version_or_higher: '5.0'
requires_redmine version_or_higher: '5.1' # redmine 6.0 is required, but version is not set in redmine source yet

begin
requires_redmine_plugin :additionals, version_or_higher: '3.2.0'
requires_redmine_plugin :additionals, version_or_higher: '4.0.0'
rescue Redmine::PluginNotFound
raise 'Please install additionals plugin (https://github.com/alphanodes/additionals)'
end
Expand Down

0 comments on commit 3b813c0

Please sign in to comment.