Skip to content

Commit

Permalink
more zsh fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
alexandermeindl committed Apr 17, 2024
1 parent 53663de commit ffdb69a
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 6 deletions.
8 changes: 8 additions & 0 deletions roles/drupal/tasks/instance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,14 @@
zsh_user_home: '{{ instance.dir }}'
when: drupal_with_zsh and instance.drupal_user is defined

- name: Set drupal home dir permission - {{ instance.name }}

Check failure on line 12 in roles/drupal/tasks/instance.yml

View workflow job for this annotation

GitHub Actions / ansible-lint

risky-file-permissions

File permissions unset or incorrect.
ansible.builtin.file:
path: '{{ instance.dir }}{{ item }}'
owner: '{{ instance.drupal_user }}'
group: '{{ instance.drupal_group | default(nginx_group) }}'
state: directory
when: instance.drupal_user is defined and instance.drupal_user != 'root'

- name: Include mysql tasks
ansible.builtin.include_tasks: instance_mysql.yml
tags: mysql
Expand Down
6 changes: 0 additions & 6 deletions roles/zsh/tasks/setup.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,3 @@
src: auto-ls.zsh
dest: '{{ auto_ls_plugin_file }}'
mode: 0644

- name: Set zsh as default shell
user:
name: "{{ ansible_user | default(ansible_env.USER) }}"
shell: /usr/bin/zsh
when: zsh_default_shell
6 changes: 6 additions & 0 deletions roles/zsh/tasks/zshrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,9 @@
ignore_errors: true
become: true
become_user: '{{ zsh_user }}'

- name: Set zsh as default shell

Check failure on line 20 in roles/zsh/tasks/zshrc.yml

View workflow job for this annotation

GitHub Actions / ansible-lint

fqcn[action-core]

Use FQCN for builtin module actions (user).
user:
name: "{{ ansible_user | default(ansible_env.USER) }}"
shell: /usr/bin/zsh
when: zsh_default_shell

0 comments on commit ffdb69a

Please sign in to comment.