Skip to content

Commit

Permalink
drop non working macro
Browse files Browse the repository at this point in the history
  • Loading branch information
alexandermeindl committed Nov 17, 2024
1 parent 9b1d303 commit 46eb6fb
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 88 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
- Redmine 5 support dropped
- Gemify support dropped
- switch icons from fontawesome to tabler
- broken tradingview macro removed

## 3.4.0

Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ Uninstall `additionals` plugin.
* reddit
* redmine.org issue and wiki page (redmine_issue and reminde_wiki)
* slideshare
* tradingview
* twitter
* user
* vimeo
Expand Down
6 changes: 0 additions & 6 deletions app/views/wiki/_tradingview.html.slim

This file was deleted.

26 changes: 19 additions & 7 deletions assets/images/icons.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
62 changes: 0 additions & 62 deletions lib/additionals/wiki_macros/tradingview_macro.rb

This file was deleted.

12 changes: 0 additions & 12 deletions test/functional/wiki_controller_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -326,18 +326,6 @@ def test_show_with_gist_macro
assert_select 'script[src=?]', 'https://gist.github.com/plentz/6737338.js'
end

def test_show_with_tradeview_macro
@request.session[:user_id] = WIKI_MACRO_USER_ID
page = WikiPage.generate! content: '{{tradingview(symbol=NASDAQ:AMZN, locale=en)}}',
title: __method__.to_s

get :show,
params: { project_id: 1, id: page.title }

assert_response :success
assert_select 'script[src=?]', 'https://s3.tradingview.com/tv.js'
end

def test_show_with_cryptocompare_macro
@request.session[:user_id] = WIKI_MACRO_USER_ID
page = WikiPage.generate! content: '{{cryptocompare(fsyms=BTC;ETH, type=header_v3)}}',
Expand Down

0 comments on commit 46eb6fb

Please sign in to comment.