This repository has been archived by the owner on Mar 29, 2021. It is now read-only.
Report catalog failures, include log source #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to catalog caching, reporting only on status == 'failed' means that failures to compile a catalog for the node won't get reliably noticed. The log format now includes log messages' source and level, to avoid conflation of e.g. two different exec resources failing with the same message.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to catalog caching, reporting only on status == 'failed' means that
failures to compile a catalog for the node won't get reliably noticed.
The log format now includes log messages' source and level, to avoid
conflation of e.g. two different exec resources failing with the same
message.