-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add landing page schema / document type #2895
Conversation
Like the coronavirus landing page schema, this will permit details objects of any structure. This is to give us an initial blank canvas while we establish the correct content model, and may be restricted further down the line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question about the description of the change which I've tagged you in elsewhere.
Also, could an example content item be added?.
Description edited. I don't think it's worth adding an example content item until we know what the structure is going to be, no? Otherwise it'll just be a confusing / imperfect mirror of the structure we've hardcoded in frontend. |
I meant an example for the basic content item, with an empty details hash. A fake content item is being duplicated in a few places in the frontend tests at the moment: It'd be nicer if one example could be pulled in. |
Ah, fair enough. Yeah, I can add that. |
78ad545
to
c004000
Compare
Moving back to draft while I investigate the failing test |
d79e10c
to
c004000
Compare
Frontend tests fixed in alphagov/frontend#4267 Ready for review again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding an example ⭐
It was added in alphagov/publishing-api#2895 It'll resolves the following error: Etl::Edition::Content::Parser::InvalidSchemaError Schema does not exist: landing_page (Etl::Edition::Content::Parser::InvalidSchemaError) https://govuk.sentry.io/issues/5990615040/events/0c7c5380338f49b29b5fe0fb1a168a25/
Like the coronavirus landing page schema, this will permit details objects of any structure. This is to give us an initial blank canvas while we establish the correct content model, and may be restricted further down the line.