Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add landing page schema / document type #2895

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Conversation

richardTowers
Copy link
Contributor

@richardTowers richardTowers commented Sep 30, 2024

Like the coronavirus landing page schema, this will permit details objects of any structure. This is to give us an initial blank canvas while we establish the correct content model, and may be restricted further down the line.

Like the coronavirus landing page schema, this will permit details
objects of any structure. This is to give us an initial blank canvas
while we establish the correct content model, and may be restricted
further down the line.
@richardTowers richardTowers marked this pull request as ready for review October 8, 2024 10:32
Copy link
Contributor

@leenagupte leenagupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question about the description of the change which I've tagged you in elsewhere.

Also, could an example content item be added?.

@richardTowers
Copy link
Contributor Author

Description edited.

I don't think it's worth adding an example content item until we know what the structure is going to be, no? Otherwise it'll just be a confusing / imperfect mirror of the structure we've hardcoded in frontend.

@leenagupte
Copy link
Contributor

leenagupte commented Oct 8, 2024

Description edited.

I don't think it's worth adding an example content item until we know what the structure is going to be, no? Otherwise it'll just be a confusing / imperfect mirror of the structure we've hardcoded in frontend.

I meant an example for the basic content item, with an empty details hash.

A fake content item is being duplicated in a few places in the frontend tests at the moment:

It'd be nicer if one example could be pulled in.

@richardTowers
Copy link
Contributor Author

Ah, fair enough. Yeah, I can add that.

@richardTowers richardTowers marked this pull request as draft October 9, 2024 09:50
@richardTowers
Copy link
Contributor Author

Moving back to draft while I investigate the failing test

@richardTowers richardTowers force-pushed the add-landing-page branch 2 times, most recently from d79e10c to c004000 Compare October 9, 2024 10:40
@richardTowers
Copy link
Contributor Author

Frontend tests fixed in alphagov/frontend#4267
Unrelated whitehall tests fixed in alphagov/whitehall#9506

Ready for review again!

@richardTowers richardTowers marked this pull request as ready for review October 10, 2024 09:28
Copy link
Contributor

@leenagupte leenagupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding an example ⭐

@richardTowers richardTowers merged commit 6f3e690 into main Oct 10, 2024
78 checks passed
@richardTowers richardTowers deleted the add-landing-page branch October 10, 2024 10:52
AgaDufrat added a commit to alphagov/content-data-api that referenced this pull request Oct 16, 2024
It was added in alphagov/publishing-api#2895

It'll resolves the following error:
  Etl::Edition::Content::Parser::InvalidSchemaError
  Schema does not exist: landing_page (Etl::Edition::Content::Parser::InvalidSchemaError)

https://govuk.sentry.io/issues/5990615040/events/0c7c5380338f49b29b5fe0fb1a168a25/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants