-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mapped_specialist_topic_content_id #2710
Remove mapped_specialist_topic_content_id #2710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one looks good too. Again it would be great to make the commit messages distinct. (I know one is just generated), I usually just use Run rake build_schemas
for the second commit so people know they can not pay it too much attention.
They are distinct, because of the second line, which is not visible by default here (you'd need to click on ...), but it is visible in the commit list. |
yep yep, I see the rest of the commit message. it would be nice to have it in the title of the commit I think. Just thinking about scrolling down the commits in the github GUI where the extended commit isn't visible by default. |
08aaa9f
to
504accc
Compare
@beccapearce I've updated commit messages and PR name. |
Thanks @unoduetre it's great to see this almost gone! You can reference that the work reverts #2385 And whilst it seems like a nitpick, I do agree with Becca's comment about simple scannable commit titles. You can see the titles for the original implementation as a guide. |
504accc
to
a7f0243
Compare
a7f0243
to
2909bd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you :)
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.
Warning
The following PR in the whitehall repository must be merged first.
What
As part of work to retire specialist topics, we temporarily stored a mapping between the archived specialist topic and its document collection conversion. We should remove this once we’re done.
Why
To keep the system clean and avoid unnecessary data.
Trello card