Remove UK Market Conformity Assessment Bodies finder #2706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The finder documents have all been unpublished. The finder itself was expected to be unpublished. That work was done in 2023, by using the unpublish rake task. Nonetheless, the code was not removed. A zendesk ticket was raised again to remove the finder as it was publicly available, in 2024. Running a rake task such as `publish_finders` would have caused the finder to be published again. Current work is to rerun the rake task and remove all code. These changes will be followed by removing the finder code from search-api and specialist-publisher.
baisa
approved these changes
Apr 15, 2024
lauraghiorghisor-tw
deleted the
remove-uk-market-conformity-assessment-bodies-finder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The finder documents have all been unpublished. The finder itself was expected to be unpublished. That work was done in 2023, by using the specialist-publisher
unpublishrake task. Nonetheless, the code was not removed from thespecialist-publisher,publlishing-apiorsearch-api, causing the finder to be accidentally published again.Once the 3 PRs are ready, the finder will be unpublished from all environments using the
unpublishrake task, then the PRs will be merged in.Trello card