Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
filter_editions doesn't support multiple filters
I added this "temporary" warning back in May last year, but I forgot to make it an error until just now. The code processing the filters is: filters.each do |link_type, target_content_id| scope = scope.where(links: { link_type:, target_content_id: }) end ... so the .where() statements would be ANDed together. If you provided multiple different filters, you'd never get any results. I've checked the logs in production, and my warning has not been served in the last 14 days (our log retention), so I'm pretty confident it's safe to tighten this up.
- Loading branch information