Landline validation dissallow premium #4143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrystalPea
approved these changes
Aug 7, 2024
rparke
force-pushed
the
landline-validation-dissallow-premium
branch
from
f3bb124
to
1084380
Compare
…d when users try to send to premium rate numbers. The request should be blocked Premium rate numbers are a known vector of attack. We want to make sure that users with sms_to_uk_landline permissions can't send messages to these numbers
rparke
force-pushed
the
landline-validation-dissallow-premium
branch
from
1084380
to
f52a19b
Compare
|
Done just slightly changed the commit message because the only thing being added now are tests |
CrystalPea
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft - needs utils merge